Skip to content
Snippets Groups Projects
Commit 66a166a3 authored by Louis-Marie Michelin's avatar Louis-Marie Michelin
Browse files

fix: express error handling

parent 683ce4f3
Branches
No related tags found
No related merge requests found
...@@ -19,11 +19,11 @@ app.use(logger("dev")); ...@@ -19,11 +19,11 @@ app.use(logger("dev"));
app.use(cors()); app.use(cors());
app.use(express.json()); app.use(express.json());
app.use(express.urlencoded({ extended: false })); app.use(express.urlencoded({ extended: false }));
app.use(jsonErrorHandler);
app.use("/", indexRouter); app.use("/", indexRouter);
app.use("/users", usersRouter); app.use("/users", usersRouter);
app.use(routeNotFoundJsonHandler); app.use(routeNotFoundJsonHandler);
app.use(jsonErrorHandler);
const port = parseInt(process.env.PORT || "3000"); const port = parseInt(process.env.PORT || "3000");
......
...@@ -3,6 +3,9 @@ ...@@ -3,6 +3,9 @@
// that needs to have four arguments as opposed to a regular middleware. // that needs to have four arguments as opposed to a regular middleware.
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const jsonErrorHandler = function (error, req, res, next) { const jsonErrorHandler = function (error, req, res, next) {
console.error(error);
if (res.headersSent) return next(error);
if (process.env.NODE_ENV === "development") { if (process.env.NODE_ENV === "development") {
return res.status(500).json({ return res.status(500).json({
message: error.toString(), message: error.toString(),
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment