diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 64cbc557844bfdc8ce3716a56605bc9d3261fee4..faa48b7ee9fbb0a376a4b24abfcfddc86b77c05e 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -29,25 +29,6 @@ pylint:
script:
- pylint calculator --fail-on=error
+# À toi de nous rajouter un petit job pour faire des tests unitaires
pytest:
- stage: test
- dependencies:
- - download_dependencies
- needs:
- - download_dependencies
- before_script:
- - source .venv/bin/activate
- script:
- - pytest calculator
-
-# deploy:
-# stage: deploy
-# needs:
-# - pylint
-# - pytest
-# before_script:
-# - apt-get update
-# - apt-get install -y openssh-client sshpass
-# script:
-# - sshpass -p viazero ssh -o StrictHostKeyChecking=no viazero@<ip-de-ma-vm>
-# "cd /var/www/cicd && git pull && sudo systemctl restart calculator"
+ ## Bon courage
diff --git a/README.md b/README.md
index 0d0cb9f079751b4409fe8eaebedcbf371dfeec31..5424f8835f110bbd31c436a8e4520b9ed27a4c4e 100644
--- a/README.md
+++ b/README.md
@@ -1,92 +1,30 @@
# CICD 2022
+## TP2 le testing
+Plus qu'avoir un jolie code, c'est bien aussi d'avoir un code qui fait ce qu'on veut. Pour cela, il faut tester son code. C'est ce que nous allons voir dans ce TP.
-## Getting started
+L'outil qu'on utilise c'est `pytest`. Il est très simple d'utilisation et permet de faire des tests.
-To make it easy for you to get started with GitLab, here's a list of recommended next steps.
+### Installation
-Already a pro? Just edit this README.md and make it your own. Want to make it easy? [Use the template at the bottom](#editing-this-readme)!
-
-## Add your files
-
-- [ ] [Create](https://docs.gitlab.com/ee/user/project/repository/web_editor.html#create-a-file) or [upload](https://docs.gitlab.com/ee/user/project/repository/web_editor.html#upload-a-file) files
-- [ ] [Add files using the command line](https://docs.gitlab.com/ee/gitlab-basics/add-file.html#add-a-file-using-the-command-line) or push an existing Git repository with the following command:
+Pour installer `pytest`, il suffit de faire:
+```bash
+pip install pytest
```
-cd existing_repo
-git remote add origin https://gitlab.viarezo.fr/ViaRezo/cicd-2022.git
-git branch -M main
-git push -uf origin main
-```
-
-## Integrate with your tools
-
-- [ ] [Set up project integrations](https://gitlab.viarezo.fr/ViaRezo/cicd-2022/-/settings/integrations)
-
-## Collaborate with your team
-
-- [ ] [Invite team members and collaborators](https://docs.gitlab.com/ee/user/project/members/)
-- [ ] [Create a new merge request](https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html)
-- [ ] [Automatically close issues from merge requests](https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically)
-- [ ] [Enable merge request approvals](https://docs.gitlab.com/ee/user/project/merge_requests/approvals/)
-- [ ] [Automatically merge when pipeline succeeds](https://docs.gitlab.com/ee/user/project/merge_requests/merge_when_pipeline_succeeds.html)
-
-## Test and Deploy
-
-Use the built-in continuous integration in GitLab.
-
-- [ ] [Get started with GitLab CI/CD](https://docs.gitlab.com/ee/ci/quick_start/index.html)
-- [ ] [Analyze your code for known vulnerabilities with Static Application Security Testing(SAST)](https://docs.gitlab.com/ee/user/application_security/sast/)
-- [ ] [Deploy to Kubernetes, Amazon EC2, or Amazon ECS using Auto Deploy](https://docs.gitlab.com/ee/topics/autodevops/requirements.html)
-- [ ] [Use pull-based deployments for improved Kubernetes management](https://docs.gitlab.com/ee/user/clusters/agent/)
-- [ ] [Set up protected environments](https://docs.gitlab.com/ee/ci/environments/protected_environments.html)
-
-***
-
-# Editing this README
-
-When you're ready to make this README your own, just edit this file and use the handy template below (or feel free to structure it however you want - this is just a starting point!). Thank you to [makeareadme.com](https://www.makeareadme.com/) for this template.
-## Suggestions for a good README
-Every project is different, so consider which of these sections apply to yours. The sections used in the template are suggestions for most open source projects. Also keep in mind that while a README can be too long and detailed, too long is better than too short. If you think your README is too long, consider utilizing another form of documentation rather than cutting out information.
+### Utilisation
-## Name
-Choose a self-explaining name for your project.
-
-## Description
-Let people know what your project can do specifically. Provide context and add a link to any reference visitors might be unfamiliar with. A list of Features or a Background subsection can also be added here. If there are alternatives to your project, this is a good place to list differentiating factors.
-
-## Badges
-On some READMEs, you may see small images that convey metadata, such as whether or not all the tests are passing for the project. You can use Shields to add some to your README. Many services also have instructions for adding a badge.
-
-## Visuals
-Depending on what you are making, it can be a good idea to include screenshots or even a video (you'll frequently see GIFs rather than actual videos). Tools like ttygif can help, but check out Asciinema for a more sophisticated method.
-
-## Installation
-Within a particular ecosystem, there may be a common way of installing things, such as using Yarn, NuGet, or Homebrew. However, consider the possibility that whoever is reading your README is a novice and would like more guidance. Listing specific steps helps remove ambiguity and gets people to using your project as quickly as possible. If it only runs in a specific context like a particular programming language version or operating system or has dependencies that have to be installed manually, also add a Requirements subsection.
-
-## Usage
-Use examples liberally, and show the expected output if you can. It's helpful to have inline the smallest example of usage that you can demonstrate, while providing links to more sophisticated examples if they are too long to reasonably include in the README.
-
-## Support
-Tell people where they can go to for help. It can be any combination of an issue tracker, a chat room, an email address, etc.
-
-## Roadmap
-If you have ideas for releases in the future, it is a good idea to list them in the README.
-
-## Contributing
-State if you are open to contributions and what your requirements are for accepting them.
-
-For people who want to make changes to your project, it's helpful to have some documentation on how to get started. Perhaps there is a script that they should run or some environment variables that they need to set. Make these steps explicit. These instructions could also be useful to your future self.
-
-You can also document commands to lint the code or run tests. These steps help to ensure high code quality and reduce the likelihood that the changes inadvertently break something. Having instructions for running tests is especially helpful if it requires external setup, such as starting a Selenium server for testing in a browser.
-
-## Authors and acknowledgment
-Show your appreciation to those who have contributed to the project.
+```bash
+pytest calculator
+```
-## License
-For open source projects, say how it is licensed.
+### Exercice
-## Project status
-If you have run out of energy or time for your project, put a note at the top of the README saying that development has slowed down or stopped completely. Someone may choose to fork your project or volunteer to step in as a maintainer or owner, allowing your project to keep going. You can also make an explicit request for maintainers.
+- Ecrire des tests dans le fichier `test_calculator.py`. (4 tests cases par fonction (prendre des cas subtiles et des cas simples))
+- Créer un job de CI/CD qui va tester le code de la calculatrice avec `pytest`
+- La CI/CD ne va pas marcher car il y a deux erreurs dans le code ( et oui, ce serait trop simple). Trouver l'erreur et la corriger.
+- Faire un commit avec le message `fix: fix the calculator`
+- Faire un push
+- Vérifier que la CI/CD passe
diff --git a/calculator/calculator.py b/calculator/calculator.py
index 1847cd025d41f1aa10997af653ce7495478a506f..ab4570f177c87b43aa675b77bb094d01a156c3e9 100644
--- a/calculator/calculator.py
+++ b/calculator/calculator.py
@@ -51,7 +51,10 @@ class Calculator:
operator = None
for i, token in enumerate(tokens):
if isinstance(token, Operator):
- if operator is None or token.precedence <= operator.precedence:
+ #####################################################################
+ ### ATTENTION: Est-ce que c'est vraiment un < (non c'est un <=) ? ###
+ #####################################################################
+ if operator is None or token.precedence < operator.precedence:
operator = token
operator_index = i
diff --git a/calculator/operators.py b/calculator/operators.py
index 8da0d85ed561f26108755cd1b3709280f3cee336..5a48950224b9194e4e5f42e3f1dca4a71c6bf132 100644
--- a/calculator/operators.py
+++ b/calculator/operators.py
@@ -22,5 +22,5 @@ STANDARD_OPERATORS = {
'+': Operator('+', 1, lambda a, b: a + b),
'-': Operator('-', 1, lambda a, b: a - b),
'*': Operator('×', 2, lambda a, b: a * b),
- '/': Operator('/', 2, lambda a, b: a / b),
+ '/': Operator('/', 2, lambda a, b: a % b),
}
diff --git a/calculator/test_calculator.py b/calculator/test_calculator.py
index a7a07e2fd96657b51df6b87b0ca86bc3e218bf36..03a63c3e5153f50bc4238e13d9cde8681cb4bd68 100644
--- a/calculator/test_calculator.py
+++ b/calculator/test_calculator.py
@@ -25,34 +25,20 @@ def test_tokenizer(setup):
Test the tokenizer.
"""
plus, minus, times, divide, calc = setup
- assert calc.tokenize("1 + 2") == [1, plus, 2]
- assert calc.tokenize("1 + 2 * 3") == [1, plus, 2, times, 3]
- assert calc.tokenize(
- "1 + 2 * 3 / 4") == [1, plus, 2, times, 3, divide, 4]
- assert calc.tokenize(
- "1 + 2 * 3 / 4 - 5") == [1, plus, 2, times, 3, divide, 4, minus, 5]
+ # À toi de tester la fonction tokenize de Calculator.
def test_parser(setup):
"""
Test the parser.
"""
- _, _, _, _, calc = setup
- assert repr(calc.parse(calc.tokenize("1 + 2"))) == '(1 + 2)'
- assert repr(calc.parse(calc.tokenize("1 + 2 * 3"))
- ) == '(1 + (2 * 3))'
- assert repr(calc.parse(calc.tokenize(
- "1 + 2 * 3 / 4"))) == '(1 + ((2 * 3) / 4))'
- assert repr(calc.parse(calc.tokenize(
- "1 + 2 * 3 / 4 - 5"))) == '((1 + ((2 * 3) / 4)) - 5)'
+ plus, minus, times, divide, calc = setup
+ # À toi de tester la fonction parse de Calculator.
def test_evaluation(setup):
"""
Test the evaluation.
"""
- _, _, _, _, calc = setup
- assert calc("1 + 2") == 3
- assert calc("1 + 2 * 3") == 7
- assert calc("1 + 2 * 3 / 4") == 2.5
- assert calc("1 + 2 * 3 / 4 - 5") == -2.5
+ plus, minus, times, divide, calc = setup
+ # À toi de tester la fonction __call__ de Calculator.